Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: migrate upload and release to new channel-map #3145

Merged
merged 1 commit into from
May 27, 2020

Conversation

sergiusens
Copy link
Collaborator

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

@sergiusens sergiusens added the Maintenance Use when updating to follow external changes or technical debt label May 26, 2020
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens
Copy link
Collaborator Author

Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #3145 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3145      +/-   ##
==========================================
- Coverage   87.53%   87.47%   -0.06%     
==========================================
  Files         253      253              
  Lines       17758    17761       +3     
  Branches     2738     2738              
==========================================
- Hits        15544    15537       -7     
- Misses       1581     1592      +11     
+ Partials      633      632       -1     
Impacted Files Coverage Δ
snapcraft/_store.py 83.68% <100.00%> (-2.16%) ⬇️
snapcraft/cli/store.py 86.69% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19393ef...e36b82b. Read the comment docs.

@sergiusens sergiusens merged commit 01b4645 into master May 27, 2020
@sergiusens sergiusens deleted the channel-map-upload branch May 27, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Use when updating to follow external changes or technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants