Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build providers: snap sw to channels if injecting #3146

Merged
merged 1 commit into from
May 27, 2020

Conversation

sergiusens
Copy link
Collaborator

Avoid refreshing to "latest/stable" which is set to the default channel
to track in snapd when installing a snap that has a revision assertion.

The results:

$ snapcraft pull --use-lxd --shell
...
snapd 2.44.3 from Canonical✓ installed
"snapd" switched to the "latest/stable" channel

core18 20200427 from Canonical✓ installed
"core18" switched to the "latest/stable" channel

snapcraft 4.0.3 installed
"snapcraft" switched to the "latest/edge" channel

ubuntu # snap list
Name       Version   Rev   Tracking       Publisher   Notes
core18     20200427  1754  latest/stable  canonical✓  base
snapcraft  4.0.3     x1    latest/edge    -           classic
snapd      2.44.3    7264  latest/stable  canonical✓  snapd

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Avoid refreshing to "latest/stable" which is set to the default channel
to track in snapd when installing a snap that has a revision assertion.

The results:

```
$ snapcraft pull --use-lxd --shell
...
snapd 2.44.3 from Canonical✓ installed
"snapd" switched to the "latest/stable" channel

core18 20200427 from Canonical✓ installed
"core18" switched to the "latest/stable" channel

snapcraft 4.0.3 installed
"snapcraft" switched to the "latest/edge" channel

ubuntu # snap list
Name       Version   Rev   Tracking       Publisher   Notes
core18     20200427  1754  latest/stable  canonical✓  base
snapcraft  4.0.3     x1    latest/edge    -           classic
snapd      2.44.3    7264  latest/stable  canonical✓  snapd
```

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens added the bug Actual bad behavior that don't fall into maintenance or documentation label May 26, 2020
Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! my bad for changing the refresh hold from 30d to 1d 🤦

@abitrolly
Copy link
Contributor

@cjp256 is it possible to add bot here for PR testing - like in multipass canonical/multipass#1559 (comment) ?

@cjp256
Copy link
Contributor

cjp256 commented May 27, 2020

That is a great idea @abitrolly! What do you think about that @sergiusens? Leave a comment after a PR pushes a snap?

@sergiusens sergiusens merged commit c15f062 into canonical:master May 27, 2020
@sergiusens sergiusens deleted the snap-switch branch May 27, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Actual bad behavior that don't fall into maintenance or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants