Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build providers: nice message on bad base #3180

Merged
merged 2 commits into from Jun 19, 2020

Conversation

sergiusens
Copy link
Collaborator

Create a new exception to handle bad bases being used for LXD.

Fixes SNAPCRAFT-1H2
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Create a new exception to handle bad bases being used for LXD.

Fixes SNAPCRAFT-1H2
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens added the Bug Actual bad behavior that don't fall into maintenance or documentation label Jun 19, 2020
Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one message reads weird, rest LGTM!

Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks!

@sergiusens sergiusens merged commit 9e569f6 into canonical:master Jun 19, 2020
@sergiusens sergiusens deleted the message-on-bad-base branch June 19, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Actual bad behavior that don't fall into maintenance or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants