Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build providers: improve warning for unknown base #3182

Merged
merged 1 commit into from Jun 19, 2020
Merged

Conversation

cjp256
Copy link
Contributor

@cjp256 cjp256 commented Jun 19, 2020

Signed-off-by: Chris Patterson chris.patterson@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
@sergiusens sergiusens added the Bug Actual bad behavior that don't fall into maintenance or documentation label Jun 19, 2020
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sold on "incompatible Snapcraft", but it is much better than the current status

@sergiusens sergiusens merged commit 7346d93 into master Jun 19, 2020
@sergiusens sergiusens deleted the unknown-base branch June 19, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Actual bad behavior that don't fall into maintenance or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants