Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: migrate legacy classic patchelf tests to spread #3242

Merged
merged 1 commit into from Aug 12, 2020
Merged

tests: migrate legacy classic patchelf tests to spread #3242

merged 1 commit into from Aug 12, 2020

Conversation

cjp256
Copy link
Contributor

@cjp256 cjp256 commented Aug 10, 2020 •
edited

Signed-off-by: Chris Patterson chris.patterson@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

@cjp256 cjp256 changed the title tests: remove expected failure case from integration test tests: remove expected failure case from legacy integration test Aug 10, 2020
sergiusens
sergiusens requested changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is already ran when we land anything in "legacy", I would just remove the test_prime module completely as this test adds little value when run from here.

@cjp256 cjp256 force-pushed the fix-legacy-classic-test branch 2 times, most recently from d779028 to c519df2 Compare August 11, 2020 19:03
@cjp256 cjp256 changed the title tests: remove expected failure case from legacy integration test tests: migrate legacy classic patchelf tests from legacy to spread Aug 11, 2020
@cjp256 cjp256 force-pushed the fix-legacy-classic-test branch 3 times, most recently from 7c6b830 to cd8eac5 Compare August 11, 2020 20:31
@cjp256 cjp256 changed the title tests: migrate legacy classic patchelf tests from legacy to spread tests: migrate legacy classic patchelf tests to spread Aug 11, 2020
tests: migrate legacy classic patchelf tests to spread
8eb1efa 
- Sort the core base rpaths so ordering is predictable.

- Add get_base() to spread helper functions.

- Remove legacy test_stage tests module.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
@sergiusens sergiusens merged commit e76a077 into master Aug 12, 2020
@sergiusens sergiusens deleted the fix-legacy-classic-test branch August 12, 2020 12:33
@sergiusens sergiusens added the Enhancement New features or optimizations label Aug 12, 2020
abitrolly pushed a commit to abitrolly/snapcraft that referenced this pull request Mar 31, 2021
@abitrolly
tests: migrate legacy classic patchelf tests to spread (canonical#3242)
5cb3836 
- Sort the core base rpaths so ordering is predictable.
- Add get_base() to spread helper functions.
- Remove legacy test_stage tests module.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiusens sergiusens sergiusens approved these changes

Assignees
No one assigned
Labels
Enhancement New features or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cjp256 @sergiusens