project loader: install dirmngr prior to configuring package repositories #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries This was previously addressed by installing the required packages in the LXD provider's setup environment and Multipass images already have the required packages installed. However, on Launchpad, the required package would not be installed. Install the required packages when additional package-repositories are configured, including 'dirmngr' and 'gnupg' using 'Repo.install_build_packages()' which accounts for already-installed packages. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
|
Tested locally with multipass, lxd, and remotely on Launchpad: https://launchpad.net/~cjp256/+snap/snapcraft-colcon-talker-listener-3597c3/+build/1125676 |
sergiusens
reviewed
Sep 23, 2020
sergiusens
approved these changes
Sep 23, 2020
abitrolly
pushed a commit
to abitrolly/snapcraft
that referenced
this pull request
Mar 31, 2021
…ries (canonical#3294) This was previously addressed by installing the required packages in the LXD provider's setup environment and Multipass images already have the required packages installed. However, on Launchpad, the required package would not be installed. Install the required packages when additional package-repositories are configured, including 'dirmngr' and 'gnupg' using 'Repo.install_build_packages()' which accounts for already-installed packages. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously addressed by installing the required packages
in the LXD provider's setup environment and Multipass images already
have the required packages installed. However, on Launchpad,
the required package would not be installed.
Install the required packages when additional package-repositories
are configured, including 'dirmngr' and 'gnupg' using
'Repo.install_build_packages()' which accounts for already-installed
packages.
Signed-off-by: Chris Patterson chris.patterson@canonical.com
./runtests.sh static?./runtests.sh tests/unit?