cli,plugins: assume that core22 base wants v2 plugins. #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to use build-base core22, some portions of cli/plugins defaulted to legacy/v1 plugins, instead of v2. Use a list of old cores, and assume anything new to be modern/v2.
xnox
force-pushed
the
build-base-core22
branch
from
c5b7302
to
7dda97e
Compare
cjp256
reviewed
Oct 26, 2020
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
sergiusens
requested changes
Oct 29, 2020
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
reviewed
Oct 30, 2020
sergiusens
approved these changes
Oct 30, 2020
abitrolly
pushed a commit
to abitrolly/snapcraft
that referenced
this pull request
Mar 31, 2021
When trying to use build-base core22, some portions of cli/plugins defaulted to legacy/v1 plugins, instead of v2. Use a list of old cores, and assume anything new to be modern/v2. Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use build-base core22, some portions of cli/plugins
defaulted to legacy/v1 plugins, instead of v2.
Use a list of old cores, and assume anything new to be modern/v2.
Add a test for a "future core2y" to use v2 plugins.
./runtests.sh static?./runtests.sh tests/unit?