repo: move apt ppa helpers into apt_ppa module #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decouples the apt ppa helpers from the _deb module and improves test coverage of the specific ppa helper functions. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
sergiusens
approved these changes
Oct 29, 2020
abitrolly
pushed a commit
to abitrolly/snapcraft
that referenced
this pull request
Mar 31, 2021
This decouples the apt ppa helpers from the _deb module and improves test coverage of the specific ppa helper functions. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
cmatsuoka
added a commit
to cmatsuoka/snapcraft
that referenced
this pull request
Feb 20, 2022
Port definitions and helpers to add apt repositories and PPAs. Original code from PRs canonical#2911, canonical#3341, canonical#3359, canonical#3363. Co-authored-by: Chris Patterson <chris.patterson@canonical.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
4 tasks
cmatsuoka
added a commit
to cmatsuoka/snapcraft
that referenced
this pull request
Feb 21, 2022
Port definitions and helpers to add apt repositories and PPAs. Original code from PRs canonical#2911, canonical#3341, canonical#3359, canonical#3363. Co-authored-by: Chris Patterson <chris.patterson@canonical.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the apt ppa helpers from the _deb module and
improves test coverage of the specific ppa helper functions.
Signed-off-by: Chris Patterson chris.patterson@canonical.com
./runtests.sh static?./runtests.sh tests/unit?