cli: allow snap-id for validate

[sergiusens]

Info API can only retrieve snap-id's for what is publicly available,
workaround the issue by allowing for using the snap-id as a fallback
to the snap-name.

LP: #1902913

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

• Have you followed the guidelines for contributing?
• Have you signed the CLA?
• Have you successfully run ./runtests.sh static?
• Have you successfully run ./runtests.sh tests/unit?

---

[nessita]

Thank you Sergio for working on this!

I've reviewed the code and it looks good to me. I would just mention that I think there are no unit tests added for the newly added if branch, do you think that's something doable/worth it?

[sergiusens]

Thanks @nessita. That code path is tested through the test_validate case we have which leverages our fake store servers.

We have a long lasting tech debt to move this block of code closer to where the unit test lives, _store.py is scheduled to disappear.

[sergiusens]

In case you want to try this out:

snap install snapcraft --classic --channel edge/pr-3349

Or refresh

snap refresh snapcraft --channel edge/pr-3349

[nessita]

I've tested this and it's not working since the added variable snap_id is colliding with an already existing snap_id. I think the new one should be named approved_snap_id or similar.

[sergiusens]

that should be fixed and more thoroughly tested now

[nessita]

I can confirm this now works as expected.

[cjp256]

LGTM