Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project schema tests: ensure json format checkers are loaded #3357

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

cjp256
Copy link
Contributor

@cjp256 cjp256 commented Nov 5, 2020

Many of the tests would fail when not running the whole test suite.
This is because the json format checkers in project_loader._config
have not been loaded. Ensure this module is imported, and mark the
import to ignore related warnings.

Signed-off-by: Chris Patterson chris.patterson@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Many of the tests would fail when not running the whole test suite.
This is because the json format checkers in project_loader._config
have not been loaded.  Ensure this module is imported, and mark the
import to ignore related warnings.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You found the culprit, nice work!

@sergiusens sergiusens merged commit 4b73a2e into canonical:master Nov 9, 2020
abitrolly pushed a commit to abitrolly/snapcraft that referenced this pull request Mar 31, 2021
…al#3357)

Many of the tests would fail when not running the whole test suite.
This is because the json format checkers in project_loader._config
have not been loaded.  Ensure this module is imported, and mark the
import to ignore related warnings.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants