extensions: use SNAP_COMMON instead of SNAP_DATA for fonts #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mitigates issues with fonts breaking when snaps update in the backround (yet to be fixed in snapd). Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cjp256
suggested changes
Nov 9, 2020
There was a problem hiding this comment.
You're missing some fixups I think:
https://github.com/snapcore/snapcraft/blob/d8f2cc6f84b059f452b982cb7eeaa5e7aa632ccc/extensions/desktop/common/fonts#L5
https://github.com/snapcore/snapcraft/blob/d8f2cc6f84b059f452b982cb7eeaa5e7aa632ccc/extensions/desktop/common/fonts#L41
SNAP_COMMON does seems more appropriate than SNAP_DATA anyhow.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
|
Good catch @cjp256 |
abitrolly
pushed a commit
to abitrolly/snapcraft
that referenced
this pull request
Mar 31, 2021
…#3361) This mitigates issues with fonts breaking when snaps update in the backround (yet to be fixed in snapd). Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mitigates issues with fonts breaking when snaps update in the
backround (yet to be fixed in snapd).
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?