plugins v1: Pin pip to supported versions #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philroche
force-pushed
the
bugfix/pin-pip-py35
branch
from
0e496bf
to
eac0bff
Compare
pip 21 dropped support for python 3.5 and python 2. pip >=21 no longer support python3.5 or python 2 and if used will result in a broken install with pip unable to install packages. * Drop support for Python 3.5 pypa/pip#9189 * Drop support for Python 2 pypa/pip#6148
philroche
force-pushed
the
bugfix/pin-pip-py35
branch
from
eac0bff
to
9dc8570
Compare
philroche
changed the title
|
Discourse topic https://forum.snapcraft.io/t/core-snaps-with-python-plugin-using-incompatible-pip-version-21-0/22369 also created |
Codecov Report
@@ Coverage Diff @@
## master #3428 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 258 258
Lines 18285 18285
=======================================
Hits 16610 16610
Misses 1675 1675
Continue to review full report at Codecov.
|
cjp256
reviewed
Jan 25, 2021
Co-authored-by: Chris Patterson <cjp256@gmail.com>
|
python/legacy-build-and-run is failing because it's invoking legacy snapcraft which also needs this fix. |
Can you point me to the source for legacy snapcraft? |
|
If you could PR this to the "legacy" branch, that'd be awesome :D |
sergiusens
approved these changes
Jan 26, 2021
abitrolly
pushed a commit
to abitrolly/snapcraft
that referenced
this pull request
Mar 31, 2021
pip 21 dropped support for python 3.5 and python 2. pip >=21 no longer support python3.5 or python 2 and if used will result in a broken install with pip unable to install packages. * Drop support for Python 3.5 pypa/pip#9189 * Drop support for Python 2 pypa/pip#6148
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Jul 20, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Jul 21, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Jul 22, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Jul 22, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Jul 26, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Aug 3, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Aug 3, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Aug 3, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Nov 24, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Nov 24, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Nov 29, 2021
This fixes a build breakage issue with the python snapcraft plugin used for building python projects. The python package manager pip dropped support for python2 and for python3.5 in pip version 21 and the plugin was patched to pin the version of pip. canonical/snapcraft#3428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip 21 dropped support for python 3.5 and python 2.
pip >=21 no longer support python3.5 or python 2 and if used will result in a
broken install with pip unable to install packages.
./runtests.sh static?./runtests.sh tests/unit?