Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: improve shell substitution logic #3599

Merged
merged 1 commit into from Nov 25, 2021
Merged

desktop: improve shell substitution logic #3599

merged 1 commit into from Nov 25, 2021

Conversation

sergiusens
Copy link
Collaborator

New shellcheck error SC2295.

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com


  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

New shellcheck error SC2295.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3599 (3148f1a) into master (3dca4d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3599   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         278      278           
  Lines       19375    19375           
=======================================
  Hits        17680    17680           
  Misses       1695     1695           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dca4d8...3148f1a. Read the comment docs.

Copy link
Contributor

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sergiusens sergiusens merged commit 3ab5323 into master Nov 25, 2021
@sergiusens sergiusens deleted the shellcheck branch November 25, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants