remote build: use channel defaults (CRAFT-568) #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
force-pushed
the
remote-build
branch
from
d94db69
to
5dcd9af
Compare
Remove the forcing of a specific channel for snapcraft and core18 (which is no longer relevant as snapcraft moved to core20). Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
remote-build
branch
from
5dcd9af
to
c095b34
Compare
|
Successfully built snapd FYI @anonymouse64 |
cmatsuoka
approved these changes
Nov 26, 2021
|
Thanks for this folks! Will this then be back-ported to the 4.x channel? Or is the code here just such that using 5.x (or I guess 6.x now) will let Launchpad auto-select the right branch of snapcraft to use for |
|
To answer my own question using edge version of snapcraft lets LP auto-select the right build-base to use with remote-build, so it just works with edge without changing channels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the forcing of a specific channel for snapcraft and
core18 (which is no longer relevant as snapcraft moved to core20).
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?