autotools v1 plugin: set correct file permissions for scripts (CRAFT-666) #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autogen.sh and bootstrap scripts had overeager permissions set when they were found not to be executable. The code has also been simplified. LP: #1951645 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cmatsuoka
approved these changes
Nov 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #3601 +/- ##
==========================================
- Coverage 91.25% 91.24% -0.01%
==========================================
Files 278 278
Lines 19375 19371 -4
==========================================
- Hits 17680 17676 -4
Misses 1695 1695
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autogen.sh and bootstrap scripts had overeager permissions set
when they were found not to be executable.
The code has also been simplified.
LP: #1951645
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?