New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added layout for libdrm, needed by AMD GPUs #3611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @kenvandine and we have a person with expertise confirming, but the unit tests have not been updated.
869972b
to
5246017
Compare
Codecov Report
@@ Coverage Diff @@
## main #3611 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 278 278
Lines 19372 19375 +3
=======================================
+ Hits 17677 17680 +3
Misses 1695 1695
Continue to review full report at Codecov.
|
This is needed by AMD GPUs.
5246017
to
31347a7
Compare
Flutter tests seem to be broken now
I will merge this as the error seems unrelated |
extensions: add layout for libdrm
extensions: add layout for libdrm
extensions: add layout for libdrm
extensions: add layout for libdrm
./runtests.sh static
?./runtests.sh tests/unit
?