Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added layout for libdrm, needed by AMD GPUs #3611

Merged
merged 1 commit into from Jan 11, 2022

Conversation

kenvandine
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Copy link

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @kenvandine and we have a person with expertise confirming, but the unit tests have not been updated.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #3611 (869972b) into main (bb816be) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 869972b differs from pull request most recent head 31347a7. Consider uploading reports for the commit 31347a7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3611   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         278      278           
  Lines       19372    19375    +3     
=======================================
+ Hits        17677    17680    +3     
  Misses       1695     1695           
Impacted Files Coverage Δ
...ternal/project_loader/_extensions/_flutter_meta.py 86.11% <ø> (ø)
.../internal/project_loader/_extensions/gnome_3_28.py 100.00% <ø> (ø)
.../internal/project_loader/_extensions/gnome_3_34.py 100.00% <ø> (ø)
.../internal/project_loader/_extensions/gnome_3_38.py 100.00% <ø> (ø)
...ft/internal/project_loader/_extensions/kde_neon.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb816be...31347a7. Read the comment docs.

This is needed by AMD GPUs.
@sergiusens
Copy link
Collaborator

Flutter tests seem to be broken now

2022-01-11T01:59:56.4756158Z ERR : Git error. Command: `git clone --mirror git://github.com/google/flutter-desktop-embedding.git /root/snap/flutter/common/flutter/.pub-cache/git/cache/flutter-desktop-embedding-87b62662532896a522efe2d4fc10c086d1a2768b`
2022-01-11T01:59:56.4758429Z     | stdout: 
2022-01-11T01:59:56.4762089Z     | stderr: Cloning into bare repository '/root/snap/flutter/common/flutter/.pub-cache/git/cache/flutter-desktop-embedding-87b62662532896a522efe2d4fc10c086d1a2768b'...
2022-01-11T01:59:56.4764053Z     | fatal: remote error: 
2022-01-11T01:59:56.4773094Z     |   The unauthenticated git protocol on port 9418 is no longer supported.
2022-01-11T01:59:56.4775171Z     | Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
2022-01-11T01:59:56.4776373Z     | exit code: 128
2022-01-11T01:59:56.4776942Z FINE: Exception type: GitException
2022-01-11T01:59:56.4778148Z FINE: package:pub/src/git.dart 62:7                                  run
2022-01-11T01:59:56.4778928Z     | ===== asynchronous gap ===========================
2022-01-11T01:59:56.4779601Z     | dart:async                                                     Future.catchError
2022-01-11T01:59:56.4780647Z     | package:pub/src/utils.dart 109:52                              captureErrors.wrappedCallback
2022-01-11T01:59:56.4781653Z     | package:stack_trace                                            Chain.capture
2022-01-11T01:59:56.4782428Z     | package:pub/src/utils.dart 122:11                              captureErrors
2022-01-11T01:59:56.4783355Z     | package:pub/src/command.dart 180:13                            PubCommand.run
2022-01-11T01:59:56.4784469Z     | package:args/command_runner.dart 209:27                        CommandRunner.runCommand
2022-01-11T01:59:56.4785652Z     | package:pub/src/command_runner.dart 173:24                     PubCommandRunner.runCommand
2022-01-11T01:59:56.4786818Z     | package:pub/src/command_runner.dart 158:20                     PubCommandRunner.run
2022-01-11T01:59:56.4787747Z     | package:dartdev/dartdev.dart 45:56                             runDartdev
2022-01-11T01:59:56.4788588Z     | /b/s/w/ir/cache/builder/sdk/pkg/dartdev/bin/dartdev.dart 11:9  main
2022-01-11T01:59:56.4789705Z ---- End log transcript ----
2022-01-11T01:59:56.4790711Z pub get failed (server unavailable) -- attempting retry 29 in 64 seconds...
2022-01-11T01:59:56.4791271Z 
2022-01-11T01:59:56.4791900Z <kill-timeout reached>
2022-01-11T01:59:56.4792514Z -----
2022-01-11T01:59:56.4792993Z .
2022-01-11T01:59:56.4794058Z 2022-01-11 01:59:50 Restoring google:ubuntu-18.04-64:tests/spread/plugins/v1/flutter/run:dev (jan110118-620832)...
2022-01-11T02:00:13.8984656Z 2022-01-11 02:00:13 Discarding google:ubuntu-18.04-64 (jan110118-620832)...
2022-01-11T02:00:14.5867580Z 2022-01-11 02:00:14 Successful tasks: 147
2022-01-11T02:00:14.5868635Z 2022-01-11 02:00:14 Aborted tasks: 0
2022-01-11T02:00:14.5869558Z 2022-01-11 02:00:14 Failed tasks: 4
2022-01-11T02:00:14.5889017Z     - google:ubuntu-18.04-64:tests/spread/plugins/v1/flutter/run:beta
2022-01-11T02:00:14.5890543Z     - google:ubuntu-18.04-64:tests/spread/plugins/v1/flutter/run:dev
2022-01-11T02:00:14.5891971Z     - google:ubuntu-18.04-64:tests/spread/plugins/v1/flutter/run:master
2022-01-11T02:00:14.5893120Z     - google:ubuntu-18.04-64:tests/spread/plugins/v1/flutter/run:stable
2022-01-11T02:00:14.5894055Z error: unsuccessful run

I will merge this as the error seems unrelated

@sergiusens sergiusens merged commit 765a6fb into canonical:main Jan 11, 2022
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 28, 2022
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 28, 2022
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 29, 2022
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants