Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: get content provider dirs from snap metadata #3871

Merged
merged 1 commit into from Aug 12, 2022

Conversation

cmatsuoka
Copy link
Contributor

@cmatsuoka cmatsuoka commented Aug 12, 2022

Obtain the list of directories exposed by content providers listed
in snap.yaml (provided that the corresponding snaps are installed
on the system).

Co-authored-by: Chris Patterson chris.patterson@canonical.com
Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

CRAFT-1246

@cmatsuoka cmatsuoka force-pushed the craft-1246/elf-content-dir branch 2 times, most recently from e4a31d4 to 2b97512 Compare August 12, 2022 15:18
Obtain the list of directories exposed by content providers listed
in snap.yaml (provided that the corresponding snaps are installed
on the system).

Co-authored-by: Chris Patterson <chris.patterson@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
@cmatsuoka
Copy link
Contributor Author

Rebased on main.

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concise and clear, nice work!

snapcraft/meta/snap_yaml.py Show resolved Hide resolved
snapcraft/meta/snap_yaml.py Show resolved Hide resolved
snapcraft/meta/snap_yaml.py Show resolved Hide resolved
@cmatsuoka cmatsuoka merged commit 5ec2faf into canonical:main Aug 12, 2022
@cmatsuoka cmatsuoka deleted the craft-1246/elf-content-dir branch August 15, 2022 15:06
cmatsuoka added a commit to cmatsuoka/snapcraft that referenced this pull request Aug 20, 2022
Obtain the list of directories exposed by content providers listed
in snap.yaml (provided that the corresponding snaps are installed
on the system).

Co-authored-by: Chris Patterson <chris.patterson@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka added a commit to cmatsuoka/snapcraft that referenced this pull request Aug 22, 2022
Obtain the list of directories exposed by content providers listed
in snap.yaml (provided that the corresponding snaps are installed
on the system).

Co-authored-by: Chris Patterson <chris.patterson@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants