parts: use part validator from craft-parts #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the common part validator implemented in craft-parts to validate part data against part and plugin models, and drop the local implementation. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
sergiusens
approved these changes
Sep 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #3909 +/- ##
==========================================
+ Coverage 89.61% 90.41% +0.80%
==========================================
Files 82 81 -1
Lines 5105 5093 -12
==========================================
+ Hits 4575 4605 +30
+ Misses 530 488 -42
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the common part validator implemented in craft-parts to validate part data against part and plugin models, and drop the local implementation.
Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com
make lint?pytest tests/unit?