tests: mock and test provider calls from lifecycle.py #3928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint
?pytest tests/unit
?Overview
Mock and test calls made to
craft-providers
fromlifecycle.py
. This code was not being tested.I also simplified the
verbosity
call to match charmcraft and rockcraft.Details
3 weeks ago, I added some unit tests for
run_in_provider()
. Today, I am extending those tests further.The test fixtures are copies of the implementations in charmcraft and rockcraft.
I'll be using these tests next week when I pull code out of the providers directory.