Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers: pass SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT to instance #3997

Merged
merged 2 commits into from Nov 30, 2022

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Nov 29, 2022

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Report from https://bugs.launchpad.net/snapcraft/+bug/1997874

SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT was not being passed into the build environment.

Inside the build environment, the default build count would be used, since the user's environment variable did not exist.

@mr-cal mr-cal changed the base branch from main to hotfix/7.2 November 29, 2022 14:07
@mr-cal mr-cal changed the base branch from hotfix/7.2 to main November 30, 2022 16:20
@mr-cal
Copy link
Collaborator Author

mr-cal commented Nov 30, 2022

Re-targeting from hotfix/7.2 to main because this is not a recent regression and can be part of the next minor release.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the providers-build-count-passthrough branch from bb2beda to 738420d Compare November 30, 2022 16:21
@mr-cal mr-cal enabled auto-merge (squash) November 30, 2022 16:21
@codecov-commenter
Copy link

Codecov Report

Merging #3997 (41a8a89) into main (0f49a75) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3997   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files          56       56           
  Lines        4154     4154           
=======================================
  Hits         3780     3780           
  Misses        374      374           
Impacted Files Coverage Δ
snapcraft/providers.py 96.55% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal merged commit 31a3990 into canonical:main Nov 30, 2022
@mr-cal mr-cal deleted the providers-build-count-passthrough branch December 14, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants