Add new plugin: rust #579

mariogrip · 2016-06-17T14:40:10Z

This adds plugin for rust (https://www.rust-lang.org/)

snappy-m-o · 2016-06-17T14:40:11Z

Can one of the admins verify this patch?

snappy-m-o · 2016-06-17T14:40:12Z

Can one of the admins verify this patch?

mmstick · 2016-06-17T21:24:08Z

Would very much like to see this as I have a hard time packaging my Rust applications without it.

WebDrake · 2016-06-18T09:08:53Z

snapcraft/tests/test_plugin_rust.py

+
+        properties = schema['properties']
+        self.assertTrue('rust-channel' in properties,
+                        'Expected "rust-verion" to be included in properties')


Looks like there are some typos here and in the self.assertTrue statements below: verion where I presume version is usually meant ... ?

Although in the specific line above, it looks like it should be Expected "rust-channel"

fixed with 05fb2a4

tsimonq2 · 2016-06-18T14:44:17Z

snapcraft/tests/test_plugin_rust.py

+            mock.call([plugin._cargo, 'install',
+                       '-j{}'.format(plugin.project.parallel_build_count),
+                       '--root', plugin.installdir])
+        ])


Nice work so far!

Coveralls points out that you are missing some tests here. In line 84 of that Coveralls page for example, shows that there is no test for an invalid Rust channel.

I don't have commit access and Coveralls could be totally wrong, but I thought I should point it out just in case Coveralls is right.

sergiusens · 2016-06-18T22:25:14Z

Hi there, thank you very much for this. I have little to no idea how rust works, but seems you have an integration test and everything so kudos!

I added a few comments here and there, but this looks really good already!

sergiusens · 2016-06-18T22:26:46Z

Also, no need to push your branch to see if things pass, I bet turnaround time would be faster for the smaller tests by running ./runtests.sh static and ./runtests.sh unit

… new-plugin-rust

sergiusens · 2016-06-20T23:23:36Z

ok to test

snappy-m-o · 2016-06-20T23:23:37Z

Can one of the admins verify this patch?

sergiusens · 2016-06-21T22:54:07Z

snapcraft/tests/test_plugin_rust.py

+from snapcraft.plugins import rust
+
+
+class MakePluginTestCase(tests.TestCase):


Maybe update the test case class name?

sergiusens · 2016-06-21T22:55:27Z

A rebase or update/merge branch with master and updating that trivial comment would be good. Going to say

ok to test

just in case something else is missing

…right

mariogrip · 2016-06-24T20:29:27Z

@sergiusens ready to test

sergiusens · 2016-06-24T21:30:21Z

@mariogrip oh, this has conflicts now :-/

If it is list plugins I guess that needs to be mocked! (our problem, not yours)

…ugin-rust

mariogrip · 2016-06-25T13:24:27Z

@sergiusens I fixed the conflict :)

sergiusens · 2016-06-25T14:59:56Z

El sábado, 25 de junio de 2016 10h'24:28 ART, Marius Gripsgard
notifications@github.com escribió:

@sergiusens I fixed the conflict :)

Tests still fail though
So close...

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#579 (comment)

Enviado con Dekko desde mi dispositivo Ubuntu

come-maiz · 2016-06-25T18:43:09Z

Thanks a lot for the great contribution!

This is missing tests for revision and channel, and for the clean pull. Let us know here or on IRC if you need a hand with this.

pura vida.

come-maiz · 2016-07-06T02:30:26Z

I'm trying to use your plugin to build https://github.com/rolandshoemaker/theca
This is the error I get: https://paste.ubuntu.com/18598513/
Do you know about it? Is there something wrong in the project or in the plugin?

Here's my yaml: https://paste.ubuntu.com/18598588/

snappy-m-o · 2016-07-06T02:30:32Z

Can one of the admins verify this patch?

snappy-m-o · 2016-07-06T02:30:34Z

Can one of the admins verify this patch?

bgdncz · 2016-07-12T13:50:19Z

@ElOpio You need nightly rust to build that, not stable AFAIU (just add rust-channel: nightly I guess)

snappy-m-o · 2016-07-12T13:50:21Z

Can one of the admins verify this patch?

snappy-m-o · 2016-07-12T13:50:24Z

Can one of the admins verify this patch?

dholbach · 2016-07-13T08:57:03Z

Can the failing tests be retried? There was some interest in this: https://twitter.com/boghison/status/753144022445723648?cn=cmVwbHk%3D&refsrc=email

come-maiz · 2016-07-13T16:18:09Z

First the conflicts need to be resolved.

bgdncz · 2016-07-16T15:33:32Z

Hi! I resolved the conflicts and squashed the commits in 427e3a6, but I have test fails in test_commands_list_plugins.py, how could that be fixed?

josepht · 2016-07-21T20:18:21Z

@boghison I'm not seeing any test failures in test_commands_list_plugins.py with your branch. I didn't see any test failures at all.

bgdncz · 2016-07-22T12:40:56Z

@josepht


======================================================================
FAIL: test_list_plugins_large_terminal (snapcraft.tests.test_commands_list_plugins.ListPluginsCommandTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/bogdan/snapcraft/snapcraft/tests/test_commands_list_plugins.py", line 43, in test_list_plugins_large_terminal
    self.assertEqual(fake_terminal.getvalue(), self.default_plugin_output)
AssertionError: 'ant [82 chars]ake  scons      \nautotools  cmake   go    gul[72 chars]nt\n' != 'ant [82 chars]ake  tar-content\nautotools  cmake   go    gul[65 chars]st\n'
Diff is 823 characters long. Set self.maxDiff to None to see it.

======================================================================
FAIL: test_list_plugins_non_tty (snapcraft.tests.test_commands_list_plugins.ListPluginsCommandTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/bogdan/snapcraft/snapcraft/tests/test_commands_list_plugins.py", line 36, in test_list_plugins_non_tty
    self.assertEqual(fake_terminal.getvalue(), self.default_plugin_output)
AssertionError: 'ant [82 chars]ake  scons      \nautotools  cmake   go    gul[72 chars]nt\n' != 'ant [82 chars]ake  tar-content\nautotools  cmake   go    gul[65 chars]st\n'
Diff is 823 characters long. Set self.maxDiff to None to see it.

======================================================================
FAIL: test_list_plugins_small_terminal (snapcraft.tests.test_commands_list_plugins.ListPluginsCommandTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/bogdan/snapcraft/snapcraft/tests/test_commands_list_plugins.py", line 57, in test_list_plugins_small_terminal
    self.assertEqual(fake_terminal.getvalue(), expected_output)AssertionError: 'ant [37 chars]der  scons      \nautotools  gradle  make    p[165 chars]  \n' != 'ant [37 chars]der  tar-content\nautotools  gradle  make    p[152 chars]  \n'
Diff is 666 characters long. Set self.maxDiff to None to see it.

----------------------------------------------------------------------
Ran 633 tests in 398.398s

FAILED (failures=3)

instead of curl

mariogrip · 2016-07-22T16:36:33Z

Sorry for the lack of updates on this, i have been a bit busy.

Ok, so now at least travis build returns success.

But autopkgtest return error:

ERROR: test_pull (snapcraft.tests.test_plugin_rust.RustPluginTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 137, in _new_conn
    (self.host, self.port), self.timeout, **extra_kw)
  File "/usr/lib/python3/dist-packages/urllib3/util/connection.py", line 91, in create_connection
    raise err
  File "/usr/lib/python3/dist-packages/urllib3/util/connection.py", line 81, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

Anyone know why?

josepht · 2016-07-22T17:33:11Z

@mariogrip I think this when it's trying to download the rustup.sh script. @ElOpio are the autopkgtests run behind a firewall that might be blocking access to https://static.rust-lang.org/rustup.sh.

FWIW, the test passes for me locally.

come-maiz · 2016-07-26T05:13:16Z

Yes they are behind a firewall. Let me request the exception.

come-maiz · 2016-07-26T14:39:49Z

retest this please

LP: #1606812

Add new plugin: rust

8b9e9cf

Fix static

99388bd

mariogrip mentioned this pull request Jun 17, 2016

Add iota snap ubuntu/snappy-playpen#76

Closed

WebDrake reviewed Jun 18, 2016
View reviewed changes

Fix typo

05fb2a4

tsimonq2 reviewed Jun 18, 2016
View reviewed changes

mariogrip added 6 commits June 19, 2016 00:29

fix typo

19e28be

Add clean_pull to wipe out rust and cargo parts

a4beaba

Fix env so it only will be used under building

53d7d06

Merge branch 'new-plugin-rust' of github.com:mariogrip/snapcraft into…

737e9c2

… new-plugin-rust

Fix some errors made when rushing to push

cd19dd9

Fix failing tests

2f23a30

sergiusens reviewed Jun 21, 2016
View reviewed changes

mariogrip added 4 commits June 24, 2016 20:20

Merge branch 'master' into new-plugin-rust

1350055

[rust-plugin] Add tests for pull, correct class name and correct copy…

f992900

…right

[rust-plugin] use curl instead of wget

9046a9c

[rust-plugin] correct expected output in test_list_plugins

9497f7b

Merge branch 'master' of github.com:ubuntu-core/snapcraft into new-pl…

005308d

…ugin-rust

sergiusens added the code-conflict label Jul 13, 2016

mariogrip added 6 commits July 22, 2016 15:40

Use internal pull of script

c99170b

instead of curl

Merge branch 'master' into new-plugin-rust

f9ad891

Fix travis build error due to missing dependencies

681faa6

Set correct calls in rust test_pull

c7c0bf5

Add mssing dependencies for autopkgtest

36f31fe

Remove unused varable

d483d1a

sergiusens removed the code-conflict label Jul 27, 2016

sergiusens merged commit 24f1def into canonical:master Jul 27, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Add new plugin: rust (canonical#579)

9eb5bcf

LP: #1606812

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new plugin: rust #579

Add new plugin: rust #579

mariogrip commented Jun 17, 2016

snappy-m-o commented Jun 17, 2016

snappy-m-o commented Jun 17, 2016

mmstick commented Jun 17, 2016

WebDrake Jun 18, 2016

mariogrip Jun 18, 2016

tsimonq2 Jun 18, 2016

sergiusens commented Jun 18, 2016

sergiusens commented Jun 18, 2016

sergiusens commented Jun 20, 2016

snappy-m-o commented Jun 20, 2016

sergiusens Jun 21, 2016

sergiusens commented Jun 21, 2016

mariogrip commented Jun 24, 2016

sergiusens commented Jun 24, 2016

mariogrip commented Jun 25, 2016

sergiusens commented Jun 25, 2016

come-maiz commented Jun 25, 2016

come-maiz commented Jul 6, 2016

snappy-m-o commented Jul 6, 2016

snappy-m-o commented Jul 6, 2016

bgdncz commented Jul 12, 2016 •

edited

snappy-m-o commented Jul 12, 2016

snappy-m-o commented Jul 12, 2016

dholbach commented Jul 13, 2016

come-maiz commented Jul 13, 2016

bgdncz commented Jul 16, 2016 •

edited

josepht commented Jul 21, 2016 •

edited

bgdncz commented Jul 22, 2016

mariogrip commented Jul 22, 2016

josepht commented Jul 22, 2016

come-maiz commented Jul 26, 2016

come-maiz commented Jul 26, 2016

		from snapcraft.plugins import rust


		class MakePluginTestCase(tests.TestCase):

Add new plugin: rust #579

Add new plugin: rust #579

Conversation

mariogrip commented Jun 17, 2016

snappy-m-o commented Jun 17, 2016

snappy-m-o commented Jun 17, 2016

mmstick commented Jun 17, 2016

WebDrake Jun 18, 2016

Choose a reason for hiding this comment

mariogrip Jun 18, 2016

Choose a reason for hiding this comment

tsimonq2 Jun 18, 2016

Choose a reason for hiding this comment

sergiusens commented Jun 18, 2016

sergiusens commented Jun 18, 2016

sergiusens commented Jun 20, 2016

snappy-m-o commented Jun 20, 2016

sergiusens Jun 21, 2016

Choose a reason for hiding this comment

sergiusens commented Jun 21, 2016

mariogrip commented Jun 24, 2016

sergiusens commented Jun 24, 2016

mariogrip commented Jun 25, 2016

sergiusens commented Jun 25, 2016

come-maiz commented Jun 25, 2016

come-maiz commented Jul 6, 2016

snappy-m-o commented Jul 6, 2016

snappy-m-o commented Jul 6, 2016

bgdncz commented Jul 12, 2016 • edited

snappy-m-o commented Jul 12, 2016

snappy-m-o commented Jul 12, 2016

dholbach commented Jul 13, 2016

come-maiz commented Jul 13, 2016

bgdncz commented Jul 16, 2016 • edited

josepht commented Jul 21, 2016 • edited

bgdncz commented Jul 22, 2016

mariogrip commented Jul 22, 2016

josepht commented Jul 22, 2016

come-maiz commented Jul 26, 2016

come-maiz commented Jul 26, 2016

bgdncz commented Jul 12, 2016 •

edited

bgdncz commented Jul 16, 2016 •

edited

josepht commented Jul 21, 2016 •

edited