New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progressbar support to most download actions #615
Add progressbar support to most download actions #615
Conversation
LP: #1597387 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
…rgiusens/snapcraft into bugfix/1597387/progressing-everywhere
I am only hesitant about the module name |
else: | ||
progress_bar = ProgressBar( | ||
widgets=[message, AnimatedMarker()], | ||
maxval=UnknownLength) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still grumpy about this.
Big 👍 here, nice work. I agree on the module name though-- indicators is better. |
LGTM |
Just ftr, all good with this branch still 😉
|
LP: #1597387 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
LP: #1597387
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com