Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progressbar support to most download actions #615

Merged

Conversation

sergiusens
Copy link
Collaborator

LP: #1597387

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

@sergiusens
Copy link
Collaborator Author

I am only hesitant about the module name snapcraft.internal.network luckily it is internal but it makes me think this should be snapcraft.internal.indicators to later on move indicator ui stuff here.

else:
progress_bar = ProgressBar(
widgets=[message, AnimatedMarker()],
maxval=UnknownLength)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still grumpy about this.

@kyrofa
Copy link
Contributor

kyrofa commented Jun 29, 2016

Big 👍 here, nice work. I agree on the module name though-- indicators is better.

@josepht
Copy link
Contributor

josepht commented Jun 29, 2016

LGTM

@sergiusens
Copy link
Collaborator Author

Just ftr, all good with this branch still 😉

======================================================================
ERROR: demos_tests.test_shout.ShoutTestCase.test_shout
----------------------------------------------------------------------
output: {{{b''}}}

Traceback (most recent call last):
  File "/tmp/adt-run.XawG72/build.6SZ/real-tree/snaps_tests/demos_tests/test_shout.py", line 25, in test_shout
    self.build_snap(self.snap_content_dir)
  File "/tmp/adt-run.XawG72/build.6SZ/real-tree/snaps_tests/__init__.py", line 159, in build_snap
    self._clean(working_dir)
  File "/tmp/adt-run.XawG72/build.6SZ/real-tree/snaps_tests/__init__.py", line 164, in _clean
    self._run_command(command, project_dir)
  File "/tmp/adt-run.XawG72/build.6SZ/real-tree/snaps_tests/__init__.py", line 187, in _run_command
    'Expected output {!r} not found.'.format(expect)) from None
snaps_tests.CommandError: Error running command 'snapcraft clean' in 'demos/shout'. Expected output <class 'pexpect.exceptions.EOF'> not found.

@sergiusens sergiusens merged commit c256727 into canonical:master Jun 29, 2016
@sergiusens sergiusens deleted the bugfix/1597387/progressing-everywhere branch June 29, 2016 20:10
kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017
LP: #1597387

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants