Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
snapcraft update if there is no cache #617
Conversation
sergiusens
added some commits
Jun 29, 2016
|
Heh, coverage decreased as I removed a bunch of test code that is not needed with this change |
|
Haha, good defense ;) . This looks good! |
kyrofa
reviewed
Jun 30, 2016
| + update() | ||
| + | ||
| + with open(self.parts_yaml) as parts_file: | ||
| + self._parts = yaml.load(parts_file) |
kyrofa
Jun 30, 2016
Member
Question here: will this simply result in a "file not found" error if the part_yaml still isn't here after the update?
sergiusens
Jun 30, 2016
Collaborator
How many ifs do you want :-P The previous statement makes it available (update). If that fails an exception will be raised already ;-)
kyrofa
Jun 30, 2016
Member
Haha, I'm just trying to consider what happens in the case of a typo. File not found, or is that caught elsewhere?
sergiusens
merged commit 9ae9f01
into
snapcore:master
Jun 30, 2016
sergiusens
deleted the
sergiusens:bugfix/1596757/update_if_no_update
branch
Jun 30, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sergiusens commentedJun 29, 2016
LP: #1596757
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com