New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snapcraft update if there is no cache #617
snapcraft update if there is no cache #617
Conversation
LP: #1596757 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Heh, coverage decreased as I removed a bunch of test code that is not needed with this change |
Haha, good defense ;) . This looks good! 👍 |
update() | ||
|
||
with open(self.parts_yaml) as parts_file: | ||
self._parts = yaml.load(parts_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question here: will this simply result in a "file not found" error if the part_yaml
still isn't here after the update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many ifs do you want :-P The previous statement makes it available (update). If that fails an exception will be raised already ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, I'm just trying to consider what happens in the case of a typo. File not found, or is that caught elsewhere?
LP: #1596757 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
LP: #1596757
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com