kernel plugin: kernel targets depending on debarch #689
Conversation
This allows using the same snapcraft.yaml to build kernels for different arches as they have different image targets. LP: #1604801 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
|
retest this please |
|
@leannogasawara any updates on testing for this? |
|
On Wed, Aug 3, 2016 at 6:21 PM, Sergio Schvezov notifications@github.com
Yep, Paolo tested this last week: <goog_1295843> "With this patch i was able to snap, from the same kernel tree, kernels for Thanks, |
|
thanks @leannogasawara :-) |
| @@ -23,8 +23,8 @@ | |||
| The following kernel specific options are provided by this plugin: | |||
|
|
|||
| - kernel-image-target: | |||
| (string; default: bzImage) | |||
| the kernel image make target to build; maps to make target. | |||
| (yaml object; default: bzImage) | |||
There was a problem hiding this comment.
Shouldn't this be: a string or a yaml object?
I think the help should explain that you can pass only one target, and how.
There was a problem hiding this comment.
Yeah probably so
| 'oneOf': [ | ||
| {'type': 'string'}, | ||
| {'type': 'object'}, | ||
| ], |
There was a problem hiding this comment.
I didn't know you could do this! Would have made some earlier changes easier.
|
I like it 👍 |
This allows using the same snapcraft.yaml to build kernels for different arches as they have different image targets. LP: #1604801 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
This allows using the same snapcraft.yaml to build kernels
for different arches as they have different image targets.
LP: #1604801
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com