Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
kernel plugin: kernel targets depending on debarch #689
Conversation
|
retest this please |
|
@leannogasawara any updates on testing for this? |
leannogasawara
commented
Aug 4, 2016
|
On Wed, Aug 3, 2016 at 6:21 PM, Sergio Schvezov notifications@github.com
Yep, Paolo tested this last week: <goog_1295843> "With this patch i was able to snap, from the same kernel tree, kernels for Thanks, |
|
thanks @leannogasawara :-) |
elopio
reviewed
Aug 4, 2016
| @@ -23,8 +23,8 @@ | ||
| The following kernel specific options are provided by this plugin: | ||
| - kernel-image-target: | ||
| - (string; default: bzImage) | ||
| - the kernel image make target to build; maps to make target. | ||
| + (yaml object; default: bzImage) |
elopio
Aug 4, 2016
Member
Shouldn't this be: a string or a yaml object?
I think the help should explain that you can pass only one target, and how.
elopio
reviewed
Aug 4, 2016
| @@ -157,6 +153,23 @@ def enable_cross_compilation(self): | ||
| self.project.kernel_arch)) | ||
| self.make_cmd.append('CROSS_COMPILE={}'.format( | ||
| self.project.cross_compiler_prefix)) | ||
| + self._set_kernel_targets() |
elopio
Aug 4, 2016
Member
I'm confused here. Why do you call it again if you already called it in the init?
sergiusens
added some commits
Aug 5, 2016
kyrofa
reviewed
Aug 5, 2016
| + 'oneOf': [ | ||
| + {'type': 'string'}, | ||
| + {'type': 'object'}, | ||
| + ], |
kyrofa
Aug 5, 2016
Member
I didn't know you could do this! Would have made some earlier changes easier.
|
I like it |
sergiusens
merged commit f0a19eb
into
snapcore:master
Aug 5, 2016
sergiusens
deleted the
sergiusens:bugfix/1604801/kernel-target-selection
branch
Aug 30, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
sergiusens commentedJul 27, 2016
This allows using the same snapcraft.yaml to build kernels
for different arches as they have different image targets.
LP: #1604801
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com