New plugin: dump #712
New plugin: dump #712
Conversation
A simple plugin that just dumps content from the specified `source` LP: #1597600 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
| super().__init__(name, options, project) | ||
|
|
||
| logger.warning("DEPRECATED: The 'copy' plugin's functionality " | ||
| "has been replaced by the 'dump' plugin, and it will " |
There was a problem hiding this comment.
maybe mention that it's replaces by the dump plugin combined with filesets. Or too much info?
There was a problem hiding this comment.
I think that's too much info for a deprecation notice. If they want to learn more they can look at the docs for that plugin.
There was a problem hiding this comment.
El 05/08/16 a las 16:50, Kyle Fazzari escribió:
In snapcraft/plugins/copy.py
#712 (comment):@@ -65,6 +67,13 @@ def schema(cls):
return schema
- def init(self, name, options, project):
super().**init**(name, options, project)
logger.warning("DEPRECATED: The 'copy' plugin's functionality ""has been replaced by the 'dump' plugin, and it will "I think that's too much info for a deprecation notice. If they want to
learn more they can look at the docs for that plugin.
It is the same text used for tar-content
There was a problem hiding this comment.
It is the same text used for tar-content
Ah, I was responding to @ElOpio, I think the text is fine. I wish github would include the comment thread when emailing...
|
This is a really simple plugin, but I think it still deserves a really simple integration test. |
| plugin.pull() | ||
| plugin.build() | ||
|
|
||
| self.assertEqual(os.listdir(plugin.installdir), |
There was a problem hiding this comment.
Is it worth verifying that parts/ stage/ etc. aren't present here?
Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Agreed. |
Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
|
👍 from me |
|
retest this please as prodstack timed out |
A simple plugin that just dumps content from the specified `source` LP: #1597600 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
A simple plugin that just dumps content from the specified
sourceLP: #1597600
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com