Implementing 'grade' support in snapcraft.yaml #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
caiobegotti
changed the title
|
I don't know where my comment went to :-/ Thanks for this. The PR has conflicts with master (at the time of the proposal even) which would be good to get sorted. |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Hmm snapcraft.tests.test_plugin_dump.DumpPluginTestCase.test_dump_symlinks seems to be failing even without any of my changes. Any idea @sergiusens if this is broken at master? |
|
@Caio1982 if you click on Update Branch now, it would all be good wrt the error you saw |
|
All passed, thanks @sergiusens ! |
|
ok to test |
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to assert the built snap quality as per the snappy design doc, see https://docs.google.com/document/d/1MOwyQXkrmMjTJnMsiisfv5Y1lrr5mwNrTxaIbMpNngc/edit#heading=h.4wp4anfwdwtq for the explanation on the purpose of grade.
An upcoming subsequent PR (still depending on snapd changes) will introduce snap-build support that use this new grade parameter.