store: download without login #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LP: #1606903 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
come-maiz
reviewed
Nov 15, 2016
| @@ -372,7 +374,8 @@ def get_package(self, snap_name, channel, arch=None): | |||
| def get(self, url, headers=None, params=None, stream=False): | |||
| if headers is None: | |||
| headers = {} | |||
| headers.update({'Authorization': _macaroon_auth(self.conf)}) | |||
| with contextlib.suppress(errors.InvalidCredentialsError): | |||
There was a problem hiding this comment.
can you explain this supress?
There was a problem hiding this comment.
We cannot assume all requests require a login, can we? We already have the with login guard on every call that requires one. If you are not logged in there is no need to _macaroon_auth
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
LP: #1606903 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP: #1606903
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com