Update HACKING.md #910
Merged
Update HACKING.md #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a very obsolete section about testing, added it to the end after installing and making sure the correct set of dependencies are in place.
come-maiz
reviewed
Nov 16, 2016
|
|
||
| ./runtests.sh [static|unit|integration|snaps] |
There was a problem hiding this comment.
This will actually try to set up an all snaps image with ubuntu-device-flash. I think that the right thing to do now is to run the snaps tests locally:
#911
come-maiz
reviewed
Nov 16, 2016
| Install the needed dependencies. | ||
|
|
||
| sudo apt install build-essential python3-dev libapt-pkg-dev libsodium-dev gcc libffi-dev | ||
| sudo apt install build-essential python3-dev libapt-pkg-dev libsodium-dev gcc libffi-dev libarchive13 |
There was a problem hiding this comment.
as I suggested in #909, would it be better to use sudo apt build-dep -y ./ ?
|
+1, with one question. |
Add squashfs-tools
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Removed a very obsolete section about testing, added it to the end after installing and making sure the correct set of dependencies are in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a very obsolete section about testing, added it to the end after installing and making sure the correct set of dependencies are in place.