sources: missing command instead of package #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are checking for missing commands and calling them packages. So commands is what needs to be exposed. In addition to that, use `shutil.which` instead of a straight out `subprocess` call. LP: #1642799 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
We are checking for missing commands and calling them packages. So commands is what needs to be exposed. In addition to that, use `shutil.which` instead of a straight out `subprocess` call. LP: #1642799 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are checking for missing commands and calling them packages. So
commands is what needs to be exposed. In addition to that, use
shutil.whichinstead of a straight out
subprocesscall.LP: #1642799
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com