many: merge fixes from 2.57.6 #12380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use systemd-tmpfiles to create the private tmp mount namespace root dir (/tmp/snap-private-tmp) on boot as owned by root with restrictive permissions. We can use this as a known location to then create per-snap private tmp mount namespace dirs (/tmp/snap-private-tmp/snap.$SNAP_INSTANCE) etc. Signed-off-by: Alex Murray <alex.murray@canonical.com>
To avoid unprivileged users being able to interfere with the creation of the private snap mount namespace, instead of creating this as /tmp/snap.$SNAP_NAME/ we can now use the systemd-tmpfiles configuration to do this for us at boot with a known fixed name (/tmp/snap-private-tmp/) and then use that as the base dir for creating per-snap private tmp mount namespaces (eg. /tmp/snap-private-tmp/snap.$SNAP_INSTANCE/tmp) etc. Signed-off-by: Alex Murray <alex.murray@canonical.com>
The output format of ls could vary depending on the local systems locale etc whereas the output of stat is fixed so use this instead to check file owner / permissions. Signed-off-by: Alex Murray <alex.murray@canonical.com>
This should ensure that any older versions of snapd that are vulnerable to this new CVE-2022-3328 are uninstalled on upgrade to the fixed version. Signed-off-by: Alex Murray <alex.murray@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the CVE-2022-3328 fixes from the release/2.57 branch back into master.