interfaces/cpu-control: allow to control cpufreq tunables #8127
Conversation
interfaces/builtin/cpu_control.go
Outdated
| /sys/devices/system/cpu/cpufreq/boost w, | ||
|
|
||
| # https://www.kernel.org/doc/html/latest/admin-guide/pm/intel_pstate.html#user-space-interface-in-sysfs | ||
| /sys/devices/system/cpu/cpufreq/intel_pstate/* r, |
There was a problem hiding this comment.
I think this should be /sys/devices/system/cpu/intel_pstate/
There was a problem hiding this comment.
This makes every file there readable and select files are made writable by the rules below.
There was a problem hiding this comment.
No @bboozzoo is right - I added an extra 'cpufreq' into the path which should be removed - will repush a fixed version soon.
Signed-off-by: Alex Murray <alex.murray@canonical.com>
alexmurray
force-pushed
the
cpu-control-governor
branch
from
fa29f23
to
47d5055
Compare
|
The failure is caused by |
interfaces/builtin/cpu_control.go
Outdated
| @@ -35,6 +35,24 @@ const cpuControlConnectedPlugAppArmor = ` | |||
| /sys/devices/system/cpu/cpu*/online rw, | |||
| /sys/devices/system/cpu/smt/* r, | |||
| /sys/devices/system/cpu/smt/control w, | |||
|
|
|||
| # https://www.kernel.org/doc/html/latest/admin-guide/pm/cpufreq.html#policy-interface-in-sysfs | |||
| /sys/devices/system/cpu/cpufreq/* r, | |||
There was a problem hiding this comment.
I wonder if this should be: /sys/devices/system/cpu/cpufreq/{,**} r,
interfaces/builtin/cpu_control.go
Outdated
|
|
||
| # https://www.kernel.org/doc/html/latest/admin-guide/pm/cpufreq.html#policy-interface-in-sysfs | ||
| /sys/devices/system/cpu/cpufreq/* r, | ||
| /sys/devices/system/cpu/cpufreq/policy*/* r, |
There was a problem hiding this comment.
With the above suggestion, this rule can go away.
interfaces/builtin/cpu_control.go
Outdated
| /sys/devices/system/cpu/cpufreq/boost w, | ||
|
|
||
| # https://www.kernel.org/doc/html/latest/admin-guide/pm/intel_pstate.html#user-space-interface-in-sysfs | ||
| /sys/devices/system/cpu/intel_pstate/* r, |
There was a problem hiding this comment.
Perhaps /sys/devices/system/cpu/intel_pstate/{,*} r, instead?
|
This is now fixed by merging #8129 |
Signed-off-by: Alex Murray <alex.murray@canonical.com>
|
Thanks for the review @jdstrand & @zyga - please see the additional commit which includes @jdstrand's suggested changes - I agree this makes more sense to try and make all attributes readable and then only specific ones writable (and this is more future proof if other subdirectories etc are added with additional attributes). |
|
Thank you everyone. IIRC @alexmurray said these changes will be released as part of 2.44 version of |
This is needed to support snaps like
auto-cpufreqto use strict confinement as per https://forum.snapcraft.io/t/classic-confinement-request-for-auto-cpufreq/15386/16Signed-off-by: Alex Murray alex.murray@canonical.com