Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misparsed requests hang #36

Closed
antonvs opened this issue Dec 7, 2010 · 3 comments
Closed

Misparsed requests hang #36

antonvs opened this issue Dec 7, 2010 · 3 comments

Comments

@antonvs
Copy link

antonvs commented Dec 7, 2010

The fileServe functions do not match a URI that is correctly encoded with %20 for spaces, so are unable to serve files with spaces in their names.

This is presumably related to issue #33, however I thought it was worth a separate issue since it prevents Snap from serving certain otherwise ordinary files.

Also, a much more minor related issue is that using a URI containing unencoded spaces results in an empty response from Snap after 30 seconds, presumably because the request line was not successfully parsed. By comparison, Apache succeeds in parsing such lines immediately, but appears to parse only up to the first space, which then typically results in a 404 error. I haven't checked the HTTP spec on this - it might be better to returned some sort of "malformed request" error.

@mightybyte
Copy link
Member

Fixed the fileServe part of this issue. The unencoded space "hang" still needs to be fixed.

@snapframework
Copy link
Collaborator

Renamed the issue for bookkeeping.

@mightybyte
Copy link
Member

Closing this for cleanup since 1.0 is a huge overhaul. Feel free to reopen if it's still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants