Use an opaque type for headers and switch representation #77

Closed
gregorycollins opened this Issue Jun 23, 2011 · 2 comments

Projects

None yet

2 participants

@gregorycollins
Snap Framework member

Right now we use "Map ByteString ByteString" for headers -- HashMap would be much faster. The headers type should be an opaque newtype instead.

@cdsmith
Snap Framework member

Sure, no harm in making it opaque. On the other hand, I'd be shocked to see any measurable performance difference, given that the keys are packed, basically always less than 5 machine words long, and the table will contain at most about two dozen entries.

@gregorycollins
Snap Framework member

This is done as of 0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment