Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an opaque type for headers and switch representation #77

Closed
gregorycollins opened this issue Jun 23, 2011 · 2 comments
Closed

Use an opaque type for headers and switch representation #77

gregorycollins opened this issue Jun 23, 2011 · 2 comments
Milestone

Comments

@gregorycollins
Copy link
Member

Right now we use "Map ByteString ByteString" for headers -- HashMap would be much faster. The headers type should be an opaque newtype instead.

@cdsmith
Copy link
Member

cdsmith commented Jun 24, 2011

Sure, no harm in making it opaque. On the other hand, I'd be shocked to see any measurable performance difference, given that the keys are packed, basically always less than 5 machine words long, and the table will contain at most about two dozen entries.

@gregorycollins
Copy link
Member Author

This is done as of 0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants