Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests timeout on slower machines #195

Closed
iliastsi opened this issue Nov 10, 2017 · 1 comment
Closed

Tests timeout on slower machines #195

iliastsi opened this issue Nov 10, 2017 · 1 comment

Comments

@iliastsi
Copy link

Hi!

Tests timeout on some slower machines. As an example, see https://buildd.debian.org/status/fetch.php?pkg=haskell-snap&arch=mipsel&ver=1.0.0.2-1&stamp=1509825048&raw=0

Would you consider increasing the default timeout for readRequestBodyHangIssue? On Debian, we use the following patch:

--- a/test/suite/Snap/Snaplet/Test/Tests.hs
+++ b/test/suite/Snap/Snaplet/Test/Tests.hs
@@ -121,7 +121,7 @@ readRequestBodyHangIssue =
     assertReadRqBody =
       do let hdl = readRequestBody 5000 >>= writeLBS
          res <- race
-                (threadDelay 1000000)
+                (threadDelay 100000000)
                 (runHandler Nothing (ST.get "" Map.empty) hdl appInit)
          either (assertFailure . ("readRequestBody timeout" ++) . show)
            (either (assertFailure . show) ST.assertSuccess) res
@mightybyte
Copy link
Member

Sorry for the delay on this. Yes, I think that patch would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants