Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to get tweets by list timeline #17

Merged
merged 3 commits into from Aug 10, 2014

Conversation

barnabywalters
Copy link
Contributor

This commit introduces the ability to fetch tweets using the Twitter list timeline API.

The group_id argument to get_activities() can now be an arbitrary string, which is used as the slug for a list. If no user_id is given then the current API user screenname is used to search for lists. If a user_id is given, it is used as the owner_screen_name query param, allowing one API user to get results for lists created by other users.

Though barely any new functionality was added in this commit I attempted to add a new test which checks that the correct URL gets requested. Unfortunately I cannot get it to pass because 'https://api.twitter.com/1.1/account/verify_credentials.json' gets called first for some reason. I have not used mox for testing before and would appreciate any help getting this test to run.

(Background: my personal use case for this functionality is to make a list of everyone on twitter I follow who doesn’t have a microformats-enabled site and follow them all through one PuSH subscription rather than separate ones for each user).

Split tests in to explicit and implicit username tests, as different code paths are taken and different requests made.
@barnabywalters
Copy link
Contributor Author

Thanks for the help in IRC, I split the test into explicit/implicit user_id tests, both of which now pass.

snarfed added a commit that referenced this pull request Aug 10, 2014
Added ability to get tweets by list timeline
@snarfed snarfed merged commit 3f9a042 into snarfed:master Aug 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants