-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluesky: support at://
synd links
#1579
Comments
Specifically I think we just need to implement Lines 87 to 95 in 71225d9
Called from here: bridgy/original_post_discovery.py Lines 526 to 534 in 71225d9
|
Yep should be doable easily enough! Will do some experimentation |
Hmm. Have done the canonicalisation and it seems to pick up the Bluesky content OK using the discover endpoint, but doesn't identify any webmention targets. |
Feel free to look at the |
I’m running locally alas! Is there a GUI for the emulator at all? |
Not any more, sadly, but you can look at them in a python shell: # in virtualenv
env APP_ID=brid-gy python
from oauth_dropins.webutil.appengine_config import ndb_client
from bluesky import Bluesky
context = ndb_client.context()
context.__enter__()
snarfed = Bluesky.get_by_id('did:plc:fdme4gb7mu7zrie7peay7tst')
print(snarfed) |
The problem appears to be that the SyndicatedPosts get inserted with their I'm not sure what to do here. If we were in a clean environment I guess we could just always canonicalise everything to a |
Understood, that makes sense. On the one hand, this is a Bluesky integration, not an ATProto integration, so I'm reluctant to go too deep into ATProto itself. On the other hand, We could backfill existing |
If this is something where it would fix itself without intervention on next crawl I’d be fine with that. The issue I guess is if it would cause duplicate web mentions to be fired |
Yes! It would effectively fix itself, by storing and using new |
The fix might be as easy as changing One catch is that we probably still want to use bsky.app URLs in the underlying |
Yeah was going to say, on reflection the at URIs would be useless to a backfeed receiver. It would actually be pretty easy to just canonicalise everything to a bsky.app URL for now- we could use DIDs rather than handles in them so they should be pretty solid well into the future. Federation is obviously its own fairly large problem but I feel like we’ll have a lot to solve all in one go when that comes in anyway? Possibly alternatively we would need to look into separating out a “silo view” and “user view” of the silo URL but that’s a refactor I wouldn’t be comfortable doing myself. |
Canonicalize to bsky.app works for me! I actually think we may be pretty ok as is for federation without any big changes, assuming we can switch all of our API requests over to the AppView (api.bsky.social) and they'll Just Work? Not 100% sure on that, but fairly confident. We'll see. |
Deployed! Let's see how it works on https://brid.gy/bluesky/did:plc:s2koow7r6t7tozgd4slc3dsg and https://brid.gy/bluesky/did:plc:bnllqqdlaspfnvesydntke4e ... |
I'm unable to get it to work for this post now it's deployed. Bridgy appears to find the relationship now but the responses to the post on Bluesky don't seem to trigger webmentions. Tried doing a recrawl/repoll/etc, nothing |
(My Bridgy page: https://brid.gy/bluesky/did:plc:ioz4ztghfznx4s5s4jxqiqun ) |
Hmm! Looks like this poll found it and canonicalized the URL to bsky.app correctly: https://brid.gy/log?module=background&start_time=1698761253&key=agdicmlkLWd5ci0LEgdCbHVlc2t5IiBkaWQ6cGxjOmlvejR6dGdoZnpueDRzNXM0anhxaXF1bgw |
Looks like there was only one response from someone else, a like. I clicked on its retry button in Bridgy and that finally did it. 🤷♂️ |
I uh...forgot about that button 🤦 |
Interesting surprise, two of the early beta testers who signed up to try the new Bluesky support use
at://
URIs as their synd links, not bsky.app links: #1453 (comment) . @JoelOtter those should be pretty straightforward to support too, right?The text was updated successfully, but these errors were encountered: