Bridgy Publish to Twitter mishandles whitespace cr by removing it

[tantek]

https://twitter.com/t/status/659200761427980288 was published by Bridgy Publish from http://tantek.com/2015/300/t1/social-web-session-w3c-tpac2015 and as you can see from the first hyperlink on the tweet:

Note the "/Social Web" - that should be "/ Social Web", and there's a return (cr) in the original that somehow Bridgy Publish removed, and thus errantly appended "Social" to the end of that IG URL

Bridgy Publish should be respecting whitespace by collapsing/keeping it as a single space at minimum, but ideally it should be preserving and passing along ALL whitespace from the original, since Twitter actually supports whitespace formatting!

https://indiewebcamp.com/note#Whitespace

[snarfed]

👍 thanks for the report!

[tantek]

Note that the Bridgy Publish POSSE copy to Facebook does not have these problems, and more to the point does preserve the line breaks!
https://www.facebook.com/photo.php?fbid=10101948228396473
Thus hopefully Bridgy Publish to Twitter can "just" be fixed to be like Bridgy Publish to Facebook!

[snarfed]

huh, interesting. that's a good point. i definitely don't understand what's going on then. odd.

[kylewm]

This looks to be a problem with post type detection. Bridgy thinks this is an article so it generates the publish content from the AS "displayName", which has html tags stripped.

(Unfortunately, this bug was hidden because real linebreaks are preserved, so if the original content had linebreaks and <br>'s, then it would appear to work properly)

    {
      "object": {
        "updated": "2015-10-27T19:48:00-0700", 
        "displayName": "https://instagram.com/p/9XVBIRA9cj/Social Web session @W3C #TPAC2015 in Sapporo, Hokkaido, Japan.", 
        "author": {
          "url": "http://tantek.com/", 
          "image": {
            "url": "http://tantek.com/logo.jpg"
          }, 
          "displayName": "Tantek \u00c7elik", 
          "objectType": "person"
        }, 
        "url": "http://tantek.com/2015/300/t1/social-web-session-w3c-tpac2015", 
        "image": {
          "url": "https://igcdn-photos-b-a.akamaihd.net/hphotos-ak-xaf1/t51.2885-15/e35/12145332_1662314194043465_2009449288_n.jpg"
        }, 
        "content": "<a class=\"auto-link figure\" href=\"https://igcdn-photos-b-a.akamaihd.net/hphotos-ak-xaf1/t51.2885-15/e35/12145332_1662314194043465_2009449288_n.jpg\"><img alt=\"a photo\" class=\"auto-embed u-photo\" src=\"https://igcdn-photos-b-a.akamaihd.net/hphotos-ak-xaf1/t51.2885-15/e35/12145332_1662314194043465_2009449288_n.jpg\"/></a> <a class=\"auto-link\" href=\"https://instagram.com/p/9XVBIRA9cj/\">https://instagram.com/p/9XVBIRA9cj/</a><br class=\"auto-break\"/><br class=\"auto-break\"/>Social Web session <a class=\"auto-link h-x-username\" href=\"https://twitter.com/W3C\">@W3C</a> #TPAC2015 in Sapporo, Hokkaido, Japan.", 
        "published": "2015-10-27T19:48:00-0700", 
        "id": "http://tantek.com/2015/300/t1/social-web-session-w3c-tpac2015", 
        "objectType": "article"
      }
    }

[snarfed]

two possible solutions, off the top of my head:

• switch to mf2util's post type detection
• when we strip html tags, replace each one with a space, then collapse spaces

thoughts?

[kylewm]

Oh actually this was fixed in snarfed/granary@fe6addf .. I hadn't closed yet because I still wanted to add a test for this exact post

[snarfed]

thanks @kylewm! confirmed manually too, the fix works in a preview of tantek's post:

[tantek]

Confirmed with live test: https://twitter.com/t/status/663016908623511552 published with Bridgy Publish from http://tantek.com/2015/311/t3/indiewebcamp-mit-the-album

[kylewm]

👍 thanks t!