Improve lock: replace spin-on-compare-and-set with spin-on-read #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snazy hi, sorry, excuse me.Have you review the PR? I think it's valuable. |
|
@killme2008 sorry, i haven't had time to dig into that yet. |
snazy
approved these changes
Oct 28, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the spin lock implementation. Replace
spin-on-test-and-setwithspin-on-read, it's more friendly with SMP per-CPU cache, and get better performance(almost 3%~7% speed up when running benchmark on my machine(ubuntu 17.10) under different threads size concurrent).