Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write anything to the Windows Registry. Or at least ask before doing it. #787

Open
libTorrentUser opened this issue Oct 5, 2022 · 4 comments

Comments

@libTorrentUser
Copy link

On Windows, Snes9x will always write entries to the registry in order to make itself available as an option to open certain file extensions.

Personally, I think that is a terrible idea. The emulator should be as portable as it claims to be. Portable in the sense that, if I want to remove it from the system, all I have to do is to delete the directory where it was extracted.

And I believe I am not alone. People seem to be asking for the same thing for more than 10 years. Really!
https://www.snes9x.com/phpbb3/viewtopic.php?t=5710
#627

Removing this "feature" altogether would be the best choice. If someone wants to add the emulator to the "open with..." list of a file extension, Windows already allows them to do that with just a couple of clicks.

But, if for some reason, people feel they really need the automatic file association thingy, could we at least change it so the emulator asks before doing anything? That could be easily done with 2 or 3 lines of code.

And last, but not least, I also believe that Windows builds should provide a script that deletes all registry entries created by Snes9x.

@OV2
Copy link
Collaborator

OV2 commented Oct 9, 2022

I might add a command line switch to remove registry entries.

@bearoso
Copy link
Collaborator

bearoso commented Mar 8, 2023

Ok, here's what I've decided on:
Snes9x will continue to add registry entries by default without asking. Most people won't know what this means, and it might be confusing and cause loss of function. You can now go into the menu under Emulation->Settings and uncheck the box that says add Snes9x to registry. Clicking OK will delete any entries created. You can set AddToRegistry to false under the [Settings] label in the snes9x.conf file before launching if you're that paranoid. There's also a command-line switch "-removeregistrykeys" that will remove entries.

@bonimy
Copy link
Contributor

bonimy commented Apr 18, 2023

Would making snes9x an installable msi with an uninstall feature also work?

@syndenbock
Copy link

The "AddToRegistry" option already exists in my snes.conf and the option to not add file type associations in the menu aswell so I guess this issue has been implemented but not closed yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants