Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernizr is not used #245

Closed
mitya57 opened this issue Sep 11, 2015 · 1 comment
Closed

Modernizr is not used #245

mitya57 opened this issue Sep 11, 2015 · 1 comment

Comments

@mitya57
Copy link
Contributor

mitya57 commented Sep 11, 2015

Hi, I wonder why does RTD theme use modernizr.min.js file.

I tried grepping JS files for usage of Modernizr object, and SASS files for typical Modernizr .foo and .no-foo classes, but could find neither of them.

Is Modernizr really used anywhere? If the answer is no, then I'll be happy to provide a pull request to get rid of it.
mitya57 added a commit to mitya57/sphinx_rtd_theme that referenced this issue Sep 16, 2015
@mitya57
Remove modernizr.js, we are not using it
2aa4ce3 
Fixes readthedocs#245.
mitya57 added a commit to mitya57/sphinx_rtd_theme that referenced this issue Sep 16, 2015
@mitya57
Remove modernizr.js, we are not using it
d458567 
Also remove no longer needed classes from root `html` element.

Fixes readthedocs#245.
@mitya57 mitya57 mentioned this issue Sep 16, 2015
Closed
@Blendify
Copy link
Member

Blendify commented Mar 9, 2017

Closing, see discussion in PR.

@Blendify Blendify closed this as completed Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitya57 @Blendify