Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature column not selectable #10593

Closed
2 tasks done
narfACS opened this issue Feb 2, 2022 · 7 comments
Closed
2 tasks done

Signature column not selectable #10593

narfACS opened this issue Feb 2, 2022 · 7 comments

Comments

@narfACS
Copy link

narfACS commented Feb 2, 2022

Debug mode

Describe the bug

When a user accepts a asset and signs for it, we can't view the signature column under their history. It is not selectable from the dropdown menu. It does show it was accepted with a tick and when you print report it does show it there.

Reproduction steps

  1. Assign an asset to user as test
  2. They get email saying to accept
  3. The click link in email and sign for asset
    ...

Expected behavior

Show signature column under user history with image of signature.

Screenshots

snipe-it signature column

Snipe-IT Version

5.3.8

Operating System

windows 10

Web Server

apache

PHP Version

8.0.10

Operating System

No response

Browser

No response

Version

No response

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

@welcome
Copy link

welcome bot commented Feb 2, 2022

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@narfACS
Copy link
Author

narfACS commented Feb 2, 2022

Sorry, forgot to add that Request signature is selected under settings > generel settings and under categories "require users to confirm acceptance" is ticked.

@snipe
Copy link
Owner

snipe commented Feb 2, 2022

I'm unable to reproduce this locally or on the demo. :(

In that blade code, the only thing that we look at as to whether to offer that field to be available is:

 @if  ($snipeSettings->require_accept_signature=='1')
                    <th class="col-md-3" data-field="signature_file" data-visible="false"  data-formatter="imageFormatter">{{ trans('general.signature') }}</th>
@endif

So if that setting is enabled, it should be a selectable option.

@narfACS
Copy link
Author

narfACS commented Feb 3, 2022

Thanks Snipe for the reply. Can I change that blade code to always show signature? And where is that blade code under the snipe-it folder?

I have also unticked the required fields, restarted the server, and tried again by ticking them but still no change.

@AkimoA
Copy link

AkimoA commented May 5, 2022

Same problem here Signature in the column selector isnt there at all . Version 5.4.4

@donron7
Copy link

donron7 commented May 21, 2022

Same here - 6.0.1.

@snipe
Copy link
Owner

snipe commented May 21, 2022

There is already a PR open that fixes this - just need to be QA'd and merged.

@snipe snipe closed this as completed in c9ef49e Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants