Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvement - Sidebar Button overflows into other elements #11754

Open
2 tasks done
yannikp opened this issue Aug 29, 2022 · 4 comments
Open
2 tasks done

Minor improvement - Sidebar Button overflows into other elements #11754

yannikp opened this issue Aug 29, 2022 · 4 comments

Comments

@yannikp
Copy link
Contributor

yannikp commented Aug 29, 2022

Debug mode

Describe the bug

The border of the sidebar-button overflows into other elements and thus shifts them slightly.

I have this custom CSS in place to fix it.
.sidebar-toggle.btn {
border-radius: 3px;
box-shadow: none;
border-top: 0px solid transparent;
border-bottom: 0px solid transparent;
padding-left: 15px;
padding-right: 15px;
padding-top: 12px;
padding-bottom: 12px;
margin-left: -47px;
margin-top: 2px;
}

Reproduction steps

Open the Snipe-IT Demo on a Desktop with a resolution of at least 1100px in width and click on "Create New" "Admin".

Expected behavior

A pristine interface :D

Screenshots

grafik

Snipe-IT Version

Snipe-IT Demo

Operating System

Snipe-IT Demo

Web Server

Snipe-IT Demo

PHP Version

Snipe-IT Demo

Operating System

Windows, macOS

Browser

Chrome, Firefox

Version

Chrome v104, Firefox v105

Device

Desktop

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

@ccj9874
Copy link

ccj9874 commented Aug 30, 2022

Can confirm that I had this issue on my instance and that the CSS you shared fixed it. I have no clue how you noticed this haha

@snipe
Copy link
Owner

snipe commented Aug 30, 2022

We'd be happy to take a PR for this :)

@yannikp
Copy link
Contributor Author

yannikp commented Aug 31, 2022

Understandable ^^
Is it this file where I would need to add the change? /resources/assets/less/overrides.less

@snipe
Copy link
Owner

snipe commented Aug 31, 2022

Yep - you don't need to submit compiled assets though, we do that on our end :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants