Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files attached to assets to actually be deleted #7674

Open
maciejgrabowy opened this issue Dec 18, 2019 · 17 comments · Fixed by #9525
Open

Files attached to assets to actually be deleted #7674

maciejgrabowy opened this issue Dec 18, 2019 · 17 comments · Fixed by #9525
Labels

Comments

@maciejgrabowy
Copy link

Server (please complete the following information):

  • Snipe-IT Version 4.8.0
  • OS: Debian 10
  • Web Server: Apache

Is your feature request related to a problem? Please describe.
Files attached to assets (and other things too, I'm assuming) via the file tab don't actually get deleted from the server after pressing the "delete" button and can be found in /storage/private_uploads/assets. They are also included in backups, which leads to significant bloat and potentially confidential documents sitting there, forever. The purge option doesn't include them as well.
Unless I'm missing something, of course, and there's something wrong on my end.

Describe the solution you'd like
An option for the files to be physically deleted would be very welcome, since manually removing them every time isn't a solution in the long run.

@snipe
Copy link
Owner

snipe commented Dec 18, 2019

The files should definitely be getting deleted. Is there anything in your error logs?

@maciejgrabowy
Copy link
Author

No, nothing gets logged.

@stale
Copy link

stale bot commented Feb 17, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Feb 17, 2020
@maciejgrabowy
Copy link
Author

Well, things are still not being deleted, so yes, it's relevant. Any ideas?

@stale
Copy link

stale bot commented Feb 19, 2020

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Feb 19, 2020
@stale
Copy link

stale bot commented Apr 19, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Apr 19, 2020
@maciejgrabowy
Copy link
Author

Annoyingly relevant, yes.

@stale
Copy link

stale bot commented Apr 19, 2020

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Apr 19, 2020
@stale
Copy link

stale bot commented Jun 20, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Jun 20, 2020
@maciejgrabowy
Copy link
Author

Yup.

@stale
Copy link

stale bot commented Jun 20, 2020

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Jun 20, 2020
@stale
Copy link

stale bot commented Aug 22, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Aug 22, 2020
@maciejgrabowy
Copy link
Author

Hi, friend bot. Yes, they're still not being deleted. If only someone could point me in the right direction...

@stale
Copy link

stale bot commented Aug 26, 2020

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Aug 26, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Dec 25, 2020
@misilot
Copy link
Contributor

misilot commented May 3, 2021

Yes, still relevant. This applies to both local storage and at least s3 storage.

@misilot
Copy link
Contributor

misilot commented May 3, 2021

Also still applies to v5.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants