Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarter not understood if written as "Q1 2018" #677

Open
joffreyvillard opened this issue Oct 12, 2018 · 1 comment
Open

Quarter not understood if written as "Q1 2018" #677

joffreyvillard opened this issue Oct 12, 2018 · 1 comment

Comments

@joffreyvillard
Copy link

Hi!
Quarters are not identified properly when written in short form:

"first quarter of 2018" > ok

{
      "entity": "snips/datetime",
      "range": {
        "end": 21,
        "start": 0
      },
      "rawValue": "first quarter of 2018",
      "slotName": "date-time",
      "value": {
        "grain": "Quarter",
        "kind": "InstantTime",
        "precision": "Exact",
        "value": "2018-01-01 00:00:00 +01:00"
      }
    }

"1st quarter of 2018" > ok

{
      "entity": "snips/datetime",
      "range": {
        "end": 19,
        "start": 0
      },
      "rawValue": "1st quarter of 2018",
      "slotName": "date-time",
      "value": {
        "grain": "Quarter",
        "kind": "InstantTime",
        "precision": "Exact",
        "value": "2018-01-01 00:00:00 +01:00"
      }
    }

"Q1 2018" > not ok

{
      "entity": "snips/datetime",
      "range": {
        "end": 7,
        "start": 3
      },
      "rawValue": "2018",
      "slotName": "date-time",
      "value": {
        "grain": "Year",
        "kind": "InstantTime",
        "precision": "Exact",
        "value": "2018-01-01 00:00:00 +01:00"
      }
    }

Best,
Joffrey

@adrienball
Copy link
Contributor

Hey, thanks for the feedback,
It is a reasonable use case indeed. We will add the support for it as soon as we can. It shouldn't be too hard.

Best,
Adrien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants