Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to add back 2.6/3.2/3.3 CI per another repo #25

Closed
wants to merge 1 commit into from

Conversation

insignification
Copy link

There's probably a way to run the CI on my own fork, but I'll just give it a try via a PR here. Can never have too many PRs :P

@insignification
Copy link
Author

Partial success - 2.6 passed but 3.2/3.3 didn't (environment issues)

For reference, here's where I got the changes from:
noahmorrison/chevron#62

I'm keeping this PR for informatonal purposes only - feel free to close it once you decide whether to add 2.6 or not.

@snoack
Copy link
Owner

snoack commented Dec 14, 2019

That is nifty! I would be more than happy to run the tests again on Python 2.6, 3.2 and 3.3.

For reference, even back then when Travis CI still supported Python 3.2 with the default image, I had to pin older versions of pytest and virtualenv, see d1e4709. Maybe that does the trick?

Anyway, even if we can't make it work on Python 3.2 and 3.3, I would still accept a merge request that at least works for Python 2.6.

@insignification
Copy link
Author

insignification commented Dec 14, 2019

Okay, I'll look into it a bit later - after the first & py38 PRs get in.

@snoack
Copy link
Owner

snoack commented Dec 14, 2019

There we go: a096f0f

@snoack snoack closed this Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants