Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SurfaceLight sphere sample distribution #66

Open
snogglethorpe opened this issue Oct 5, 2013 · 0 comments
Open

Optimize SurfaceLight sphere sample distribution #66

snogglethorpe opened this issue Oct 5, 2013 · 0 comments

Comments

@snogglethorpe
Copy link
Owner

Currently Sphere::Sampler and Sphere2::Sampler just evenly sample over the half-sphere for the Surface::Sampler::sample_from_viewpoint method, which doesn't yield particularly good results.

It might be better to sample evenly over the field-of-view cone instead, e.g. with cone_sample.

When the sphere is far away, the sampling domain won't be particularly different, but the distribution will probably be better.

This affects issue #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant