Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test workflow #41

Merged
merged 12 commits into from Oct 26, 2020
Merged

Update test workflow #41

merged 12 commits into from Oct 26, 2020

Conversation

sondrelg
Copy link
Member

Changes

  • Adds django matrix with supported package versions and python 3.9 to the test workflow 馃殌
  • Removes unnecessary isort config
  • Updates package metadata to include python 3.9 and django 3.1

@JonasKs
Copy link
Member

JonasKs commented Oct 22, 2020

S e x y馃ぉ I鈥檒l look more closely when I get home, but this all looks awesome!

@sondrelg
Copy link
Member Author

It's also possible to use pre-commit for linting checks instead of black+isort+flake8, and configure a pre-commit cache.

and I was hoping to configure test to run on pushes to master or pull requests, but seems that's not possible, so think I'll revert to pull_request only. Do you agree?

@sondrelg sondrelg marked this pull request as ready for review October 22, 2020 17:41
@sondrelg sondrelg requested a review from JonasKs October 22, 2020 17:41
@sondrelg
Copy link
Member Author

sondrelg commented Oct 22, 2020

All in all I think we increase the test runtime by ~30 seconds

image

but now there's a dedicated job for each combination of all supported python and django versions, as documented in the packages metadata + a linting job to make sure any new code is consistent with the existing code base.

image

@JonasKs
Copy link
Member

JonasKs commented Oct 26, 2020

Do you want to update this to use your action before merging?

@sondrelg sondrelg merged commit 499a423 into master Oct 26, 2020
@sondrelg sondrelg deleted the test-workflow branch October 26, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants