Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally use deprecated default_app_config #77

Merged
merged 1 commit into from Feb 12, 2022

Conversation

dustinchilson
Copy link
Contributor

default_app_config is being removed in Django 4.1 and a new warning has shown up since django 3.2

https://docs.djangoproject.com/en/dev/internals/deprecation/#deprecation-removed-in-4-1

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #77 (151e275) into master (388707d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines          920       922    +2     
=========================================
+ Hits           920       922    +2     
Impacted Files Coverage Δ
django_guid/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388707d...151e275. Read the comment docs.

@JonasKs
Copy link
Member

JonasKs commented Feb 8, 2022

Hi, thank you for this!

Linting fails, would you like to run pre-commit run --all-files? 😊

@dustinchilson
Copy link
Contributor Author

Linting fails, would you like to run pre-commit run --all-files?

I did this locally and got the same errors as CI. Looking it doesn't look like any of the files I changed.

If I pin the flake8-type-checking to v 1.3.0 I get less errors if 1.2.0 I get none in flake8. So It looks like the issue is in there.

In the rst section I'm not sure what's happening.

@JonasKs
Copy link
Member

JonasKs commented Feb 9, 2022

Ah, I see. You're right! Sorry.

Seems like @sondrelg's type checker has caught a few things. I'll try to look into it this week and create a release ASAP. Thank you so much 🚀

@sondrelg
Copy link
Member

Rebasing on master should fix the linting errors now @dustinchilson 🙂

`default_app_config` is being removed in Django 4.1 and a new warning has shown up since django 3.2

https://docs.djangoproject.com/en/dev/internals/deprecation/#deprecation-removed-in-4-1
@dustinchilson
Copy link
Contributor Author

@sondrelg @JonasKs All rebased, thx

@JonasKs JonasKs merged commit 64f094c into snok:master Feb 12, 2022
@JonasKs
Copy link
Member

JonasKs commented Feb 12, 2022

Thank you! I'll create a GitHub release next time on a PC! Have a good weekend 😊

@dustinchilson dustinchilson deleted the dustinchilson-patch-1 branch February 13, 2022 01:22
@JonasKs
Copy link
Member

JonasKs commented Mar 7, 2022

So sorry I forgot about this, @dustinchilson! I've released a new version now.

@dustinchilson
Copy link
Contributor Author

@JonasKs No problem, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants