-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to install poetry plugins #53
Comments
Thanks for bringing this up @pbk0 👏 I just have a few questions, in case you already know:
|
Can you make sure if you have multiple poetry installations? (try curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py > get-poetry.py
python get-poetry.py --uninstall
rm get-poetry.py
curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/install-poetry.py > install-poetry.py
python install-poetry.py --uninstall
python install-poetry.py --version 1.2.0a2
rm install-poetry.py
poetry --version BTW the plugin gets installed in isolation alongside isolated poetry installation and it does not mess up with local installations lockfile.
If I am correct this can happen only if poetry is installed via |
I think you were right about dual installations, got it to work now 👍 So the solution would just be something like specifying: - uses: snok/install-poetry@v1
with:
version: 1.2.0a2
plugins: |
poetry-plugin-a
poetry-plugin-b or - uses: snok/install-poetry@v1
with:
version: 1.2.0a2
plugins: poetry-plugin-a, poetry-plugin-b or - uses: snok/install-poetry@v1
with:
version: 1.2.0a2
plugins: poetry-plugin-a poetry-plugin-b Where the That sounds doable 👍 Would you be interested in creating a PR for this @pbk0? |
Yes, it's doable. I will try and send you PR. Anyways the plugins are a new feature and don't expect it to stabilize soon. |
May I ask about the status of this feature? I see the issue was closed, but I'm not sure if the feature was implemented. PS - thanks for creating this plugin. I'm a recent convert to the Poetry ecosystem, it's awesome. |
The feature was not implemented, so re-opening 👍 I don't have time to implement this currently, but a PR is very welcome 🙂 |
I'd be happy to attempt a PR!
EDIT: Ah, it's explained in scripts/README.md . So, looks like just |
Poetry 1.2+ will now support plugins. It will be a good idea to support installing plugins if the poetry version is 1.2+.
That is by adding the below lines to the
main.sh
script:The text was updated successfully, but these errors were encountered: