Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Don't Upgrade Generics #22

Closed
Kurt-von-Laven opened this issue Sep 24, 2021 · 1 comment
Closed

Don't Upgrade Generics #22

Kurt-von-Laven opened this issue Sep 24, 2021 · 1 comment

Comments

@Kurt-von-Laven
Copy link

The typing package supports generics, whereas collections.abc does not. Hence, when this tool replaces typing types that are used as generics with their equivalent types in collections.abc, it breaks the build. I found it helpful to run this tool as a one-off and then manually undo these cases though, so thank you!

@sondrelg
Copy link
Member

Thanks for reporting this @Kurt-von-Laven; I had no idea the collection types weren't supported for generics! 🙂

Would you be interested in trying to raise a PR for this? I've not spent a lot of time in the code lately, but think a fix might just require adding an if statement or two.

Would you also be able to provide a few concrete examples of when the tool behaves incorrectly? 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants